Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add aws_sqs_queue_policy #8657

Merged
merged 1 commit into from
Sep 5, 2016

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Sep 5, 2016

This may conflict with #8650 so it's probably best to merge that one 1st and then let me rebase this PR.

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSSQSQueuePolicy'
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSSQSQueuePolicy -timeout 120m
=== RUN   TestAccAWSSQSQueuePolicy_basic
--- PASS: TestAccAWSSQSQueuePolicy_basic (30.99s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    31.006s

@stack72
Copy link
Contributor

stack72 commented Sep 5, 2016

@radeksimko this LGTM! Ran all SQS tests just to make sure

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSQS'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/05 09:52:33 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSQS -timeout 120m
=== RUN   TestAccAWSSQSQueue_importBasic
--- PASS: TestAccAWSSQSQueue_importBasic (19.02s)
=== RUN   TestAccAWSSQSQueuePolicy_basic
--- PASS: TestAccAWSSQSQueuePolicy_basic (23.01s)
=== RUN   TestAccAWSSQSQueue_basic
--- PASS: TestAccAWSSQSQueue_basic (45.93s)
=== RUN   TestAccAWSSQSQueue_redrivePolicy
--- PASS: TestAccAWSSQSQueue_redrivePolicy (26.26s)
=== RUN   TestAccAWSSQSQueue_Policybasic
--- PASS: TestAccAWSSQSQueue_Policybasic (32.51s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    146.747s

@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants