Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add API Gateway Client Certificate #8775

Merged

Conversation

radeksimko
Copy link
Member

This would be useful for an upcoming API Gateway Stage PR so that we can test these resources together.

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSAPIGatewayClientCertificate'
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSAPIGatewayClientCertificate -timeout 120m
=== RUN   TestAccAWSAPIGatewayClientCertificate_basic
--- PASS: TestAccAWSAPIGatewayClientCertificate_basic (28.37s)
=== RUN   TestAccAWSAPIGatewayClientCertificate_importBasic
--- PASS: TestAccAWSAPIGatewayClientCertificate_importBasic (16.67s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    45.065s

Read: resourceAwsApiGatewayClientCertificateRead,
Update: resourceAwsApiGatewayClientCertificateUpdate,
Delete: resourceAwsApiGatewayClientCertificateDelete,
Importer: &schema.ResourceImporter{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a test for the import func?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is there, search for TestAccAWSAPIGatewayClientCertificate_importBasic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! It's usually in a different file - maybe we need to remove that from elsewhere as it is just extra files in the repo :)

@radeksimko radeksimko force-pushed the f-aws-api-gateway-client-cert branch from ece4b3b to 46d5d51 Compare September 12, 2016 09:10
@radeksimko
Copy link
Member Author

PR updated.

@stack72
Copy link
Contributor

stack72 commented Sep 20, 2016

Hi @radeksimko

This LGTM! :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSAPIGatewayClientCertificate'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/20 16:46:47 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSAPIGatewayClientCertificate -timeout 120m
=== RUN   TestAccAWSAPIGatewayClientCertificate_basic
--- PASS: TestAccAWSAPIGatewayClientCertificate_basic (32.62s)
=== RUN   TestAccAWSAPIGatewayClientCertificate_importBasic
--- PASS: TestAccAWSAPIGatewayClientCertificate_importBasic (20.08s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    52.714s

@stack72 stack72 merged commit e9e1896 into hashicorp:master Sep 20, 2016
@radeksimko radeksimko deleted the f-aws-api-gateway-client-cert branch September 20, 2016 15:52
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants