-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add API Gateway Client Certificate #8775
provider/aws: Add API Gateway Client Certificate #8775
Conversation
Read: resourceAwsApiGatewayClientCertificateRead, | ||
Update: resourceAwsApiGatewayClientCertificateUpdate, | ||
Delete: resourceAwsApiGatewayClientCertificateDelete, | ||
Importer: &schema.ResourceImporter{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a test for the import func?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is there, search for TestAccAWSAPIGatewayClientCertificate_importBasic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! It's usually in a different file - maybe we need to remove that from elsewhere as it is just extra files in the repo :)
ece4b3b
to
46d5d51
Compare
PR updated. |
Hi @radeksimko This LGTM! :)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This would be useful for an upcoming API Gateway Stage PR so that we can test these resources together.
Test plan