terraform: consistent variable values for booleans #9751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6447 This ensures that all variables of type string are consistently converted to a string value upon running Terraform. The place this is done is in the `Variables()` call within the `terraform` package. This is the function responsible for loading and merging the variables from the various sources and seems ideal for proper conversion to consistent values for various types. We actually already had tests to this effect. This also adds docs that talk about the fake-ish boolean variables Terraform currently has and about how in future versions we'll likely support them properly, which can cause BC issues so beware.
This fixes a test but also loosens the requirements of Variables() so that the Validate() call on Terraform can actually catch those errors.
jbardin
approved these changes
Oct 31, 2016
mengesb
added a commit
to mengesb/tf_chef_server
that referenced
this pull request
Nov 18, 2016
- [Julian Dunn] - Fix [terraform.tfvars.example] missing double quote - [Julian Dunn] - Stringify the booleans (hashicorp/terraform#9751) - [Brian Menges] - Update chef client and server versions to latest - [Brian Menges] - Add kitchen-terraform and tests
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6447
This ensures that all variables of type string are consistently
converted to a string value upon running Terraform.
The place this is done is in the
Variables()call within theterraformpackage. This is the function responsible for loading andmerging the variables from the various sources and seems ideal for
proper conversion to consistent values for various types. We actually
already had tests to this effect.
This also adds docs that talk about the fake-ish boolean variables
Terraform currently has and about how in future versions we'll likely
support them properly, which can cause BC issues so beware.