provider/aws: aws_ebs_volume datasource #9753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -159,6 +159,7 @@ func Provider() terraform.ResourceProvider { | |||
| "aws_s3_bucket_object": dataSourceAwsS3BucketObject(), | |||
| "aws_subnet": dataSourceAwsSubnet(), | |||
| "aws_security_group": dataSourceAwsSecurityGroup(), | |||
| "aws_volume": dataSourceAwsVolumes(), | |||
There was a problem hiding this comment.
I'm not sure I can really explain why, but it feels weird to me not to name this aws_ebs_volume... I guess because it doesn't really feel "specific enough" without it, even though I'd concede that the naming scheme until now has generally been to use generic names for EC2 stuff.
A slightly stronger (but still rather weak) argument would be that when paired with aws_ebs_snapshot these would group together nicely in an alphabetical list.
There was a problem hiding this comment.
Agreed - this was only during WIP to make sure it was viable :)
stack72
changed the title
stack72
force-pushed
the
f-aws-volume-datasource
branch
3 times, most recently
from
3f5e3a5 to
5808f76
Compare
stack72
changed the title
stack72
force-pushed
the
f-aws-volume-datasource
branch
from
5808f76 to
2a808f3
Compare
jen20
approved these changes
Nov 1, 2016
| volume = filteredVolumes[0] | ||
| } | ||
|
|
||
| log.Printf("[DEBUG] aws_volume - Single Volume found: %s", *volume.VolumeId) |
| return sortedVolumes[len(sortedVolumes)-1] | ||
| } | ||
|
|
||
| // populate the numerous fields that the image description returns. |
|
|
||
| # aws\_ebs\_volume | ||
|
|
||
| Use this data source to get the information of an EBS volume for use in other |
This will allows us to filter a specific ebs_volume for attachment to an aws_instance ``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEbsVolumeDataSource_'✹ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/11/01 12:39:19 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEbsVolumeDataSource_ -timeout 120m === RUN TestAccAWSEbsVolumeDataSource_basic --- PASS: TestAccAWSEbsVolumeDataSource_basic (28.74s) === RUN TestAccAWSEbsVolumeDataSource_multipleFilters --- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (28.37s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws57.145s ```
stack72
force-pushed
the
f-aws-volume-datasource
branch
from
2a808f3 to
76e1997
Compare
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
This will allows us to filter a specific ebs_volume for attachment to an aws_instance ``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEbsVolumeDataSource_'✹ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/11/01 12:39:19 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEbsVolumeDataSource_ -timeout 120m === RUN TestAccAWSEbsVolumeDataSource_basic --- PASS: TestAccAWSEbsVolumeDataSource_basic (28.74s) === RUN TestAccAWSEbsVolumeDataSource_multipleFilters --- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (28.37s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws57.145s ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allows us to filter a specific ebs_volume for attachment to an
aws_instance
fixes #9620