Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/azurerm: Event Hubs Consumer Groups #9902

Merged
merged 14 commits into from
Dec 28, 2016
Merged

provider/azurerm: Event Hubs Consumer Groups #9902

merged 14 commits into from
Dec 28, 2016

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 6, 2016 •
edited
Loading

@tombuildsstuff tombuildsstuff mentioned this pull request Nov 6, 2016
Merged
5 tasks
@tombuildsstuff tombuildsstuff force-pushed the azurerm-eventhubs-consumer-groups branch from c0c0c3b to 9470ece Compare November 7, 2016 21:09
@tombuildsstuff tombuildsstuff force-pushed the azurerm-eventhubs-consumer-groups branch from b40a5bb to 2cf7913 Compare November 17, 2016 06:22
@tombuildsstuff tombuildsstuff force-pushed the azurerm-eventhubs-consumer-groups branch from 2cf7913 to f880994 Compare December 27, 2016 14:58
@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Dec 27, 2016 •
edited
Loading

Upgraded to v7.0.1 of the SDK / fixed what I thought was an idempotency issue

@tombuildsstuff
Copy link
Contributor Author

Tests pass - the builds failing for an unrelated reason (ssh timeout):

$ TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMEventHubConsumerGroup -timeout 120m
=== RUN   TestAccAzureRMEventHubConsumerGroup_importBasic
--- PASS: TestAccAzureRMEventHubConsumerGroup_importBasic (360.09s)
=== RUN   TestAccAzureRMEventHubConsumerGroup_importComplete
--- PASS: TestAccAzureRMEventHubConsumerGroup_importComplete (356.24s)
=== RUN   TestAccAzureRMEventHubConsumerGroup_basic
--- PASS: TestAccAzureRMEventHubConsumerGroup_basic (357.92s)
=== RUN   TestAccAzureRMEventHubConsumerGroup_complete
--- PASS: TestAccAzureRMEventHubConsumerGroup_complete (358.76s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	1433.027s

I could have sworn I'd opened an issue about eventHubPath previously - but I can't find it. It's settable in the SDK but not actually returned from the API - so for now I've ignored the field altogether.

Is it worth blocking this PR on that - or shall that become a secondary PR?

cc @stack72

@tombuildsstuff tombuildsstuff force-pushed the azurerm-eventhubs-consumer-groups branch from 66ff434 to 3010444 Compare December 27, 2016 23:21
@tombuildsstuff tombuildsstuff force-pushed the azurerm-eventhubs-consumer-groups branch from 3010444 to f2b8d36 Compare December 27, 2016 23:21
@tombuildsstuff tombuildsstuff changed the title [WIP] provider/azurerm: Event Hubs Consumer Groups provider/azurerm: Event Hubs Consumer Groups Dec 28, 2016
@stack72
Copy link
Contributor

stack72 commented Dec 28, 2016

This LGTM! Thanks @tombuildsstuff :)

@stack72 stack72 merged commit cc09ac6 into hashicorp:master Dec 28, 2016
@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Dec 29, 2016 •
edited
Loading

Opened an issue for the eventHubPath field - Azure/azure-rest-api-specs#838

Mongey pushed a commit to Mongey/terraform that referenced this pull request Jan 6, 2017
@tombuildsstuff @Mongey
provider/azurerm: Event Hubs Consumer Groups (hashicorp#9902)
9e9d509 
* Documentation

* Scaffolding Consumer Groups

* Linting

* Adding a missing </li>

* User MetaData needs to explicitly be optional

* Typo

* Fixing the test syntax

* Removing the eventHubPath field since it appears to be deprecated

* Added a Complete import test

* WIP

* Updating to use SDK 7.0.1

* Calling the correct method

* Removing eventhubPath and updating the docs

* Fixing a typo
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/azurerm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @stack72