provider/random: Add b64_std to random_id #9903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes three related changes to the `random_id` resource: 1. Deprecate the `b64` attribute 2. Introduce a new `b64_url` attribute which functions in the same manner as the original `b64` attribute 3. Introduce a new `b64_std` attribute which uses standard base64 encoding for the value rather than URL encoding. Resource identifiers continue to use URL encoded base 64. The reason for adding standard encoding of the base 64 value is to allow the use of generated values as a Serf Encryption Key for separating Consul clusters - these rely on standard encoding and do not permit some characters which are allowed by URL encoding. `b64_url` is introduced in order that there is consistency in specifying the desired encoding during interpolation.
phinze
approved these changes
Nov 6, 2016
|
|
||
| byteLength := d.Get("byte_length").(int) | ||
| bytes := make([]byte, byteLength) | ||
|
|
||
| n, err := rand.Reader.Read(bytes) | ||
| if n != byteLength { | ||
| return fmt.Errorf("generated insufficient random bytes") |
There was a problem hiding this comment.
No need to cover this here, but noting that this catches the global rand source and should probably be reworked to use a local one at some point.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes three related changes to the
random_idresource:b64attribute.b64_urlattribut which functions in the same manner as the originalb64attribute.b64_stdattribute which uses standard base64 encoding for the value rather than URL encoding.Resource identifiers continue to use URL encoded base 64.
The reason for adding standard encoding of the base 64 value is to allow the use of generated values as a Serf Encryption Key for separating Consul clusters - these rely on standard encoding and do not permit some characters which are allowed by URL encoding.
b64_urlis introduced in order that there is consistency in specifying the desired encoding during interpolation.We also clean up the code for the random provider and move to using the more recent schema-provided Noop functions in preference to custom functions in the provider.
cc @sean-, @stack72