Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of backend/s3: Add wrong bucket region handling to all of S3 client into v1.6 #33906

Conversation

gdavison
Copy link
Contributor

Backport of #33885


Uses a middleware handler to return bucketRegionError for all S3 operations.

Works around aws/aws-sdk-go-v2#2282

Target Release

1.6.0

Draft CHANGELOG entry

Not user facing

@gdavison gdavison requested a review from a team as a code owner September 18, 2023 22:40
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@alisdair alisdair deleted the backport/s3/f-add-wrong-s3-region-error/constantly-genuine-herring branch September 20, 2023 13:40
Copy link
Contributor

github-actions bot commented Dec 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants