Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sleep to preStop lifecycle #125

Closed
infa-bsurber opened this issue Nov 28, 2019 · 1 comment · Fixed by #188
Closed

add sleep to preStop lifecycle #125

infa-bsurber opened this issue Nov 28, 2019 · 1 comment · Fixed by #188
Assignees
Labels
chart Area: helm chart enhancement New feature or request
Milestone

Comments

@infa-bsurber
Copy link

one tip to remove 502s and 503s for customers on pod rotation is to add a sleep to the preStop lifecycle.
this extra time allows for traffic to stop routing to the pod before the SIGTERM is sent to the running process (because this removal of the routing is asynchronous)

pretty good explanation in this article: https://blog.gruntwork.io/gracefully-shutting-down-pods-in-a-kubernetes-cluster-328aecec90d

@jasonodonnell
Copy link
Contributor

This is a good tip, I think we could add it. If you would like to create a PR to add it, let me know, else I will add it in the next development cycle.

@jasonodonnell jasonodonnell added the enhancement New feature or request label Nov 28, 2019
@tvoran tvoran added the chart Area: helm chart label Jan 23, 2020
@jasonodonnell jasonodonnell added this to the v0.4.0 milestone Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart Area: helm chart enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants