From dfdb14b5546ddc620122ec8048c33e4a6adc8379 Mon Sep 17 00:00:00 2001 From: Konstantin Demin Date: Tue, 29 Nov 2022 19:21:09 +0300 Subject: [PATCH] ui: mfa: use proper request id generation (#17835) * ui: mfa: use proper request id generation Fixes: 712cc9ee, ca14c191 Signed-off-by: Konstantin Demin Signed-off-by: Konstantin Demin --- changelog/17835.txt | 3 +++ ui/mirage/handlers/mfa-login.js | 6 +----- 2 files changed, 4 insertions(+), 5 deletions(-) create mode 100644 changelog/17835.txt diff --git a/changelog/17835.txt b/changelog/17835.txt new file mode 100644 index 000000000000..3c48884364c5 --- /dev/null +++ b/changelog/17835.txt @@ -0,0 +1,3 @@ +```release-note:improvement +ui: mfa: use proper request id generation +``` diff --git a/ui/mirage/handlers/mfa-login.js b/ui/mirage/handlers/mfa-login.js index 61dd66bb9919..34d4b7583e88 100644 --- a/ui/mirage/handlers/mfa-login.js +++ b/ui/mirage/handlers/mfa-login.js @@ -93,11 +93,7 @@ export default function (server) { } else if (user === 'mfa-j') { [mfa_constraints, methods] = generator([m('pingid')]); // use to test push failures } - const numbers = (length) => - Math.random() - .toString() - .substring(2, length + 2); - const mfa_request_id = `${numbers(8)}-${numbers(4)}-${numbers(4)}-${numbers(4)}-${numbers(12)}`; + const mfa_request_id = crypto.randomUUID(); const mfa_requirement = { mfa_request_id, mfa_constraints,