Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new vault patch CLI command is needed #18507

Closed
maxb opened this issue Dec 20, 2022 · 3 comments
Closed

A new vault patch CLI command is needed #18507

maxb opened this issue Dec 20, 2022 · 3 comments
Labels

Comments

@maxb
Copy link
Contributor

maxb commented Dec 20, 2022

One of the more helpful things about the Vault CLI, is that it mostly provides elegant CLI syntax for performing various HTTP API calls.

However, in recent Vault versions, the HTTP PATCH verb has started to be used. Support for this is missing in the Vault CLI.

I'm not referring specifically to KV v2 PATCH, for which there is vault kv patch .... Rather, I'm thinking about APIs such as pki/issuer/:issuer_ref which require the PATCH method to perform reconfiguration of options, without wiping everything that has already been set. There is no way to invoke this from the CLI.

I propose the existing family of "basic HTTP operation" Vault CLI commands (read, write, list, delete) should be supplemented by the addition of vault patch, which functions identically to vault write, except that it uses the PATCH HTTP method.

@cipherboy
Copy link
Contributor

@maxb This should already be in your 1.13 main builds from #17650, let me know if that doesn't work :-)

@maxb
Copy link
Contributor Author

maxb commented Dec 21, 2022

Ah, right... I was, of course, trying to use 1.12.2 to configure 1.12.2's PKI engine when I ran into this.

It would be kind of nice to backport to 1.12 since it's the natural way to configure PKI in 1.12, but I guess that's pretty low importance in the grand scheme of things.

@cipherboy
Copy link
Contributor

cipherboy commented Dec 21, 2022

Yeah, since this is a new feature, we're internally hesitant to backport it... 1.13 will have it and then you can run newer CLI versions if desired :-)

I do agree though, would be nice to have with 1.11 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants