Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault v1.1.3 Breaks Compatibility for Consul Storage Config #6854

Closed
Xtigyro opened this issue Jun 10, 2019 · 2 comments · Fixed by #6859
Closed

Vault v1.1.3 Breaks Compatibility for Consul Storage Config #6854

Xtigyro opened this issue Jun 10, 2019 · 2 comments · Fixed by #6859
Assignees

Comments

@Xtigyro
Copy link

Xtigyro commented Jun 10, 2019

Describe the bug

    storage "consul" {
      address = "unix:///consul-unix-socket/consul-client.sock"
      scheme = "http"
      disable_registration = "{{default "false" .Values.Vault.DisableConsulRegistration}}"
    }

Leads to:
Error initializing storage of type consul: address should be host[:port], not URL

That config has perfectly worked up until now (including in Vault v.1.1.2).

@mgritter mgritter self-assigned this Jun 10, 2019
@mgritter
Copy link
Contributor

This is a regression I introduced; I can't find a quick workaround. Altering the address so that it passes the check I added means it won't work with other components; for example, unix:/tmp/consul-client.sock isn't parsed by the client library.

@Xtigyro
Copy link
Author

Xtigyro commented Jun 11, 2019

@mgritter Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants