Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch performKeyUpgrades context canceled errors #7065

Closed
briankassouf opened this issue Jul 3, 2019 · 1 comment · Fixed by #7070
Closed

Catch performKeyUpgrades context canceled errors #7065

briankassouf opened this issue Jul 3, 2019 · 1 comment · Fixed by #7070
Labels
beta
Milestone
1.2

Comments

@briankassouf
Copy link
Contributor

Standbys that fail to perform key upgrades shut themselves down, this is because they no longer have the latest keyring or master key and would be unable to perform certain decryptions. However if performKeyUpgrades fails due to a context canceled error we should not shutdown since this likely just means we are changing state.
@briankassouf briankassouf added this to the 1.2 milestone Jul 3, 2019
@jefferai jefferai added the beta label Jul 5, 2019
@jefferai
Copy link
Member

jefferai commented Jul 5, 2019

Adding to beta as it's a functional change so would be good to get out in case it causes issues for anyone testing.

@briankassouf briankassouf mentioned this issue Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

core: Don't shutdown if key upgrades fail due to canceled context hashicorp/vault
2 participants
@jefferai @briankassouf