Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authenticated metrics endpoint #7494

Closed
tmhdgsn opened this issue Sep 19, 2019 · 4 comments · Fixed by #7550
Closed

authenticated metrics endpoint #7494

tmhdgsn opened this issue Sep 19, 2019 · 4 comments · Fixed by #7550

Comments

@tmhdgsn
Copy link

tmhdgsn commented Sep 19, 2019

Why is the metric endpoint authenticated?

Is there any interest to have an unauthenticated metrics endpoint at all?
/cc @miekg

@jefferai
Copy link
Member

jefferai commented Sep 19, 2019

It's authenticated because our customers who originally drove the metrics endpoint creation were concerned about someone being able to glean an understanding about the state of the system using whatever metrics are both there now and might show up in the future.

We've been considering making it possible to mark it as unauthenticated, possibly on a per-listener basis.

@tmhdgsn
Copy link
Author

tmhdgsn commented Sep 19, 2019

personally we consider all of our metrics to be public, ultimately they end accessible by anyone so authentication at scrape time doesn't make sense.

@jwmajors81
Copy link

One impact of requiring the metrics endpoint to be authenticated is that it fills up the vault audit logs. Since we started scraping the metrics endpoint with prometheus an addition 11,000 events have been added to the vault audit log file per day (with the associated response payload), which is causing the logs to get much larger. It would be ideal if this endpoint was not authenticated.

@jefferai
Copy link
Member

jefferai commented Oct 2, 2019

@jwmajors81 We're aware of this, and it's one of the factors of why we're considering allowing it to be marked unauthenticated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants