Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrimSpace secret engine path #8268

Closed
Wouter0100 opened this issue Jan 30, 2020 · 2 comments · Fixed by #19913
Closed

TrimSpace secret engine path #8268

Wouter0100 opened this issue Jan 30, 2020 · 2 comments · Fixed by #19913
Labels
bug Used to indicate a potential bug core/plugin ui
Milestone

Comments

@Wouter0100
Copy link

Wouter0100 commented Jan 30, 2020

Is your feature request related to a problem? Please describe.
I created a secret engine, and was unable to access it afterwards through most tools (CLI, Ansible lookup module). After debugging it for an hour, I came across the space in the beginning of my secret path. I accidentally entered a space before the path.

Describe the solution you'd like
When I create a new Secrets Engine, it would be awesome that the path will be trimmed - just in case. I don't see any reason why a space would be useful in this place.

Describe alternatives you've considered
I haven't really considered any other solutions. Maybe trimming in the Vault UI or showing a notification ("You have a space in front of the path, are you sure?") would also suffice.

Explain any additional use-cases
n/a

Additional context
n/a

@catsby catsby added bug Used to indicate a potential bug core/plugin labels Jan 31, 2020
@catsby
Copy link
Contributor

catsby commented Jan 31, 2020

Hey @Wouter0100 - just to be clear, the extra space was added when you enabled the secret with vault secrets enable -path= correct? As opposed to when the plugin was registered to the catalog as in https://www.vaultproject.io/docs/internals/plugins/#plugin-catalog

@Wouter0100
Copy link
Author

Thanks for your reply! No, I created the secret engine through the UI.

@catsby catsby added the ui label Feb 5, 2020
@pbernal pbernal added this to the triaged milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug core/plugin ui
Projects
None yet
3 participants