Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error call in array migration #354

Closed
ProofOfKeags opened this issue Feb 19, 2019 · 0 comments · Fixed by #741
Closed

error call in array migration #354

ProofOfKeags opened this issue Feb 19, 2019 · 0 comments · Fixed by #741

Comments

@ProofOfKeags
Copy link

I am attempting to do an initial schema migration (generate database from empty schema) and it is complaining that it cannot do array migrations, It appears that the offending error call is here:

pgUnboundedArrayType :: PgDataTypeSyntax -> PgDataTypeSyntax
pgUnboundedArrayType (PgDataTypeSyntax _ syntax serialized) =
    PgDataTypeSyntax (error "Can't do array migrations yet")
                     (syntax <> emit "[]")
                     (pgDataTypeJSON (object [ "unbounded-array" .= fromBeamSerializedDataType serialized ]))

Is there any reason I can't just replace error with an actual description or oid and PR that in, or is that change substantially more involved than it first appears? At the moment I only need it to do the trivial migrations for me, so this seems like it would be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants