Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External command system missing from 3.12.1.0 release notes #10164

Open
hasufell opened this issue Jul 1, 2024 · 7 comments
Open

External command system missing from 3.12.1.0 release notes #10164

hasufell opened this issue Jul 1, 2024 · 7 comments

Comments

@hasufell
Copy link
Member

hasufell commented Jul 1, 2024

b27fd21

https://github.com/haskell/cabal/blob/master/release-notes/cabal-install-3.12.1.0.md

@ffaf1
Copy link
Collaborator

ffaf1 commented Jul 1, 2024

This is because #9063 was merged without a changelog.d file.

We can of course modify the release notes, but I wonder if this warrants more exposure.

@geekosaur
Copy link
Collaborator

I was under the impression this feature is still somewhat experimental, and its further evolution depends on what early adopters find they would benefit from. So it could go either way but probably the balance weighs toward encouraging said early adopters.

@Mikolaj
Copy link
Member

Mikolaj commented Jul 2, 2024

It's already documented in the rtd manual, so it's not hidden anyway.

@andreabedini
Copy link
Collaborator

@hasufell Let me understand, what if your expectation w.r.t. to fixing this issue? The cabal-install-3.12.1.0 tarball is out and cannot be changed. Do you think making a changelog entry for 3.12.2.0 is a good solution? Thanks.

@hasufell
Copy link
Member Author

You can fix it in:

  • git
  • readthedocs
  • release announcements

Not sure how many people care about the tarball.

@geekosaur
Copy link
Collaborator

We've already retroactively edited release notes: #10134
I also note that we (deliberately) point people to the changelog files in master in preference to pregenerated files, e.g. on Hackage. In fact, I think the files in the tarball just point you to https://github.com/haskell/cabal/blob/master/Cabal/ChangeLog.md and https://github.com/haskell/cabal/blob/master/cabal-install/changelog.

@hasufell
Copy link
Member Author

If there's nothing to be done, then feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants