Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hole fits: Don't suggest trivial infinite recursion #1804

Open
anka-213 opened this issue May 7, 2021 · 2 comments
Open

Hole fits: Don't suggest trivial infinite recursion #1804

anka-213 opened this issue May 7, 2021 · 2 comments
Labels

Comments

@anka-213
Copy link
Contributor

anka-213 commented May 7, 2021

It would be nice if hole fits wouldn't suggest trivial infinite recursion.

If I write the code

foobar :: Foo -> Bar
foobar = _

I would almost never want the definition

foobar :: Foo -> Bar
foobar = foobar

Currently, this is the first suggestion it gives.


Originally posted by @anka-213 in #883 (comment)

@Ailrun Ailrun added the type: enhancement New feature or request label May 7, 2021
@July541
Copy link
Collaborator

July541 commented May 7, 2021

I think to make this the lowest priority is a good choice.

@rowanG077
Copy link

Are there any cases where this is actually the code you want? I would rather have that it never suggest this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants