Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wingman's hyphenation dependency is broken in the 1.2 release #1976

Closed
isovector opened this issue Jun 25, 2021 · 1 comment · Fixed by #1979
Closed

Wingman's hyphenation dependency is broken in the 1.2 release #1976

isovector opened this issue Jun 25, 2021 · 1 comment · Fixed by #1979
Labels
CI Continuous integration component: wingman old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@isovector
Copy link
Collaborator

Wingman uses hyphenation to come up with better variable names. But I didn't realize that hyphenation uses external files for the language data. These aren't bundled with the release, so Wingman crashes when trying to produce variable names for any non-symbolic types. It's not picked up in CI presumably because we build from source, which ensures the language dependencies exist.
@isovector isovector added component: wingman type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. CI Continuous integration old_type: distribution labels Jun 25, 2021
This was referenced Jun 25, 2021
Merged
Closed
@isovector
Copy link
Collaborator Author

Related: ekmett/hyphenation#18

@mergify mergify bot closed this as completed in #1979 Jun 25, 2021
@Tarmean Tarmean mentioned this issue Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration component: wingman old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable hyphenation embedding isovector/haskell-language-server
1 participant
@isovector