hls-class-plugin - Add placeholders for all class methods

[batkot]

Added code action for creating placeholders for all not implemented class methods. Action is skipped when only required methods are missing to avoid duplication.

Currently it's available only when minimal class definition is not met, wasn't sure how to locate class instances 🤔

Close #3017

[Ailrun]

I don't have enough time at least for now, sorry for the delay. This is some minor comment. Hopefully I could have some timespan soon for a fuller review.

[Ailrun]

The performance is probably better with nubOrdOn snd instead of this.

Suggested change

	$ nubBy (\(_, x) (_,y) -> x == y)
	$ nubOrdOn snd

[michaelpj]

Maybe @July541 could take a look?

[July541]

I can do a review this weekend if @Ailrun is busy still.

[July541]

Many thanks for your improvement! please add tests for it robust.

[July541]

Currently it's available only when minimal class definition is not met, wasn't sure how to locate class instances 🤔

class-plugin relies on ghc diagnostic to produce code actions, you can't have code actions for all instances under the current mechanism.

haskell-language-server/plugins/hls-class-plugin/src/Ide/Plugin/Class/CodeAction.hs

Lines 207 to 208 in dfd8f0b

	isClassMethodWarning :: T.Text -> Bool
	isClassMethodWarning = T.isPrefixOf "• No explicit implementation for"

[batkot]

Thanks for review, @July541 👍

class-plugin relies on ghc diagnostic to produce code actions, you can't have code actions for all instances under the current mechanism.

Yeah I noticed that, I was just wondering if there's a nicer way to do that 🤔 But I don't know GHC codebase that well (not to say at all) 😅

[July541]

Everything looks fine, thank you for your work!

[July541]

I was just wondering if there's a nicer way to do that

I think we can ignore diagnostics and emit the code actions directly.