Multi-stage builds ?

[aaparmeggiani]

Hi there, are multi-stage builds supported/planned? (or am I missing something??)

remote: Sending build context to Docker daemon 122.9 kB
remote: Step 1/17 : FROM elixir:1.7-alpine AS builder
remote: Error parsing reference: "elixir:1.7-alpine AS builder" is not a valid repository/tag: invalid reference format

--

% gitkube version
v0.2.1

Thanks in advance,
Andre

[aaparmeggiani]

Hmm .. needs docker >= 17.05

Multi-stage builds are a new feature requiring Docker 17.05 or higher on the daemon and client.

[tirumaraiselvan]

I guess we need to update https://github.com/hasura/gitkube/blob/master/build/gitkubed/Dockerfile . Any takers?

[seanprashad]

Hey @tirumaraiselvan! I'd like to give this a shot. Would we need to update:

gitkube/build/gitkubed/Dockerfile

Line 7 in 23fc06b

&& curl -o /tmp/docker-1.12 'https://get.docker.com/builds/Linux/x86_64/docker-1.12.6.tgz' \

to be && curl -o /tmp/docker-1.17.05 'https://get.docker.com/builds/Linux/x86_64/docker-1.17.05.tgz' \

and the associated lines that reference /tmp/docker-1.12 to /tmp/docker-1.17.05?

[tirumaraiselvan]

@seanprashad yes, that should be enough.