Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeApprove is deprecated #17

Open
hats-bug-reporter bot opened this issue Oct 26, 2023 · 2 comments
Open

safeApprove is deprecated #17

hats-bug-reporter bot opened this issue Oct 26, 2023 · 2 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@hats-bug-reporter
Copy link

Github username: @pehdfms
Submission hash (on-chain): 0x7e26041a12c3bc9744f108c8c931dd97b3b2b36103b3e4280b7d18d04aa4f531
Severity: low

Description:
Description
safeApprove function is deprecated.

HatClaimsManager
Line 299
Line 308
@hats-bug-reporter hats-bug-reporter bot added the bug Something isn't working label Oct 26, 2023
@pehdfms
Copy link

pehdfms commented Oct 26, 2023

Recommendation: use safeIncreaseAllowance and safeDecreaseAllowance instead

@bahurum
Copy link

bahurum commented Oct 31, 2023

There is no issue here because allowance is set back to 0 after usage

@bahurum bahurum added the invalid This doesn't seem right label Oct 31, 2023
@jellegerbrandy jellegerbrandy mentioned this issue Nov 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pehdfms @bahurum