New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeApprove() function is deprecated #396

Closed

masaun opened this issue Oct 30, 2022 · 5 comments

Labels

invalid SubmissionAuditCompetition wontfix

masaun commented Oct 30, 2022 •

edited

Loading

Severity

Medium

Vulnerability description

safeApprove() functuin has been deprecated by OpenZeppelin team: Deprecate SafeERC20.safeApprove OpenZeppelin/openzeppelin-contracts#2268
- However, safeApprove() is used in the following lines in this repo:

Mitigation steps

Instead of using safeApprove() function, safeIncreaseAllowance() function and safeDecreaseAllowance() function should be used.
https://docs.openzeppelin.com/contracts/2.x/api/token/erc20#SafeERC20-safeIncreaseAllowance-contract-IERC20-address-uint256-
https://docs.openzeppelin.com/contracts/2.x/api/token/erc20#SafeERC20-safeDecreaseAllowance-contract-IERC20-address-uint256-

The text was updated successfully, but these errors were encountered:

Contributor

lirona commented Oct 30, 2022 •

edited

Loading

hi @masaun thanks for the submission. this is nice :)
but unfortunately not relevant for our use case:
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/36951d58386b9fee81b237e6c6626c9115ccef3a/contracts/token/ERC20/utils/SafeERC20.sol#L51

have you submitted this issue through our dapp as well?

Author

masaun commented Oct 31, 2022 •

edited

Loading

@lirona Yes. but I have submitted this issue via your dApp just now. (Sorry for delay to submit it via your dApp)

but unfortunately not relevant for our use case:

Got it. I will try to find another issues.

Contributor

lirona commented Oct 31, 2022

great, good luck :)

Contributor

lirona commented Oct 31, 2022

can you please send the transaction hash to https://t.me/Hatsofir ? we don't see it

Author

masaun commented Nov 2, 2022

can you please send the transaction hash to https://t.me/Hatsofir ? we don't see it

@lirona Sure, I sent it just now. Could you check it?

lirona closed this as completed

jellegerbrandy added SubmissionAuditCompetition wontfix invalid labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment