KDE-open is not installed on Gnome systems by default

[CjS77]

Haveno tries to use kde-open when popping up a "Insufficient funds" message. kde-open is not installed on Gnome systems by deault.

Ideally, there's a more universal way to do this; or try and detect that we're using a Gnome system and use the equivalent command.

Log file:

Jul-26 08:31:04.445 [JavaFX Application Thread] INFO  h.d.c.c.c.PopOver: hide:200.0 ms 
Jul-26 08:31:13.542 [JavaFX Application Thread] INFO  h.d.c.c.c.PopOver: hide:200.0 ms 
Jul-26 08:31:23.374 [JavaFX Application Thread] INFO  h.c.o.CreateOfferService: create and get offer with offerId=JKDLDJ-d2ff01de-4617-4120-8af9-174123ceda6b-109, currencyCode=EUR, direction=SELL, fixedPrice=null, useMarketBasedPrice=true, marketPriceMargin=0.001, amount=2939200000000, minAmount=752600000000, securityDeposit=0.15 
Jul-26 08:31:24.502 [OpenOfferManager] INFO  h.c.o.OpenOfferManager: Adding open offer JKDLDJ-d2ff01de-4617-4120-8af9-174123ceda6b-109 
Jul-26 08:31:24.503 [Thread-6638] WARN  h.c.o.OpenOfferManager: Unable to split or schedule funds for offer JKDLDJ-d2ff01de-4617-4120-8af9-174123ceda6b-109: Not enough funds to schedule offer 
Jul-26 08:31:24.503 [Thread-6638] WARN  h.c.o.OpenOfferManager: Error processing pending offer JKDLDJ-d2ff01de-4617-4120-8af9-174123ceda6b-109: Not enough funds to schedule offer 
Jul-26 08:31:24.503 [Thread-6638] INFO  h.c.o.OpenOfferManager: Removing open offer JKDLDJ-d2ff01de-4617-4120-8af9-174123ceda6b-109 
Jul-26 08:31:24.503 [Thread-6638] INFO  h.c.t.ClosedTradableManager: checking closed trades eligibility for having sensitive data cleared 
Jul-26 08:31:24.503 [Thread-6638] INFO  h.c.x.w.XmrWalletService: resetAddressEntriesForOpenOffer offerId=JKDLDJ-d2ff01de-4617-4120-8af9-174123ceda6b-109 
Jul-26 08:31:24.503 [Thread-6638] INFO  h.c.x.w.XmrWalletService: swap addressEntry with address 85HPL7NGMU1fNdBwngjdNr8BWSrjHUsd9jJNjj56j8DsTSr7cpmvTwMYPnCkJW5dHyYbWWG2hn8CFjFbTbM1SQEDPC4myeh and offerId JKDLDJ-d2ff01de-4617-4120-8af9-174123ceda6b-109 from context OFFER_FUNDING to available 
Jul-26 08:31:39.767 [JavaFX Application Thread] INFO  h.c.u.DesktopUtil: Trying to exec: cmd = kde-open args = %s file = /home/<snip>/.local/share/Haveno-reto/haveno.log 
Jul-26 08:31:39.769 [JavaFX Application Thread] WARN  h.c.u.DesktopUtil: Error running command. java.io.IOException: Cannot run program "kde-open": error=2, No such file or directory 
Jul-26 08:31:39.769 [JavaFX Application Thread] INFO  h.c.u.DesktopUtil: Trying to exec: cmd = gnome-open args = %s file = /home/cayle/.local/share/Haveno-reto/haveno.log 
Jul-26 08:31:39.771 [JavaFX Application Thread] WARN  h.c.u.DesktopUtil: Error running command. java.io.IOException: Cannot run program "gnome-open": error=2, No such file or directory 
<snip>
Jul-26 08:31:39.776 [JavaFX Application Thread] INFO  h.c.u.DesktopUtil: Process is running. 

[woodser]

It's also trying gnome-open, which shows a warning from your logs. That's not working on the Gnome system either, or does the popup show?

I think it's just showing a warning that it's already running.

[CjS77]

Good catch. I didn't notice that.

So here's what's installed on my system:

$ gnome-open --help
gnome-open: command not found

$ open --help
xdg-open - opens a file or URL in the user's preferred application

Synopsis

xdg-open { file | URL }

xdg-open { --help | --manual | --version }

Use 'man xdg-open' or 'xdg-open --manual' for additional info.

To my recollection, I've never changed anything from the defaults on my Ubuntu system:

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.4 LTS
Release:	22.04
Codename:	jammy

[CjS77]

gnome-open is apparently deprecated in Ubuntu.
https://askubuntu.com/questions/1046400/what-should-be-used-instead-of-the-deprecated-gnome-open-in-ubuntu-18-04

[CjS77]

xdg-open and simply open as additional fallbacks would probably catch most issues.

[CjS77]

Just poked my nose into DesktopUtil.java and I see xdg-open is already a fallback.

I didn't take a screenshot of the error dialog that popped up, unfortunately, so presumably that actually returned with true .

I reckon, you could close this issue, since the error was likely somewhere else. If it happens again, I'll due better DD and submit another issue.

[woodser]

Great yes please report any errors in the UI.