Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction IDs in legacy UI trade info views #478

Closed
Tracked by #377
woodser opened this issue Nov 11, 2022 · 0 comments · Fixed by #482
Closed
Tracked by #377

Fix transaction IDs in legacy UI trade info views #478

woodser opened this issue Nov 11, 2022 · 0 comments · Fixed by #482
Labels
good first issue Good for newcomers

Comments

@woodser
Copy link
Contributor

woodser commented Nov 11, 2022

Currently when a trade is taken, the trade info (i) view indicates the following information:

image

  • Maker fee transaction ID is some tx hash. Where does that tx hash come from?
  • Maker fee transaction ID should be removed.
  • The "Deposit transaction IDs" should be labeled "Your deposit transaction ID" and "Peer's deposit transaction ID".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant