Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbar to payment account popups [0.25 XMR] #656

Closed
woodser opened this issue Aug 8, 2023 · 9 comments · Fixed by #673
Closed

Add scrollbar to payment account popups [0.25 XMR] #656

woodser opened this issue Aug 8, 2023 · 9 comments · Fixed by #673
Assignees
Labels
💰bounty There is a bounty on this issue good first issue Good for newcomers

Comments

@woodser
Copy link
Contributor

woodser commented Aug 8, 2023

This issue requests adding a scrollbar to popups for payment account terms if they're too long to fit on the screen, which can happen with low resolution screens.

For example, the popup with terms for the "Pay by Mail" payment account is long:

image
@woodser woodser added good first issue Good for newcomers a:legacy UI labels Aug 8, 2023
@woodser
Copy link
Contributor Author

woodser commented Aug 19, 2023

This can be implemented by using a ScrollPane with Overlay.java's message field.

@woodser woodser added the 💰bounty There is a bounty on this issue label Aug 20, 2023
@github-actions
Copy link

There is a bounty on this issue, the amount is in the title. The reward will be awarded to the first person or group of people who resolves this issue.

If you are starting to work on this bounty, please write a comment, so that we can assign the issue to you. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progresses. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of our bounty system.

@woodser woodser changed the title Add scrollbar to payment account popups Add scrollbar to payment account popups [0.25 XMR] Aug 20, 2023
@coinstudent2048
Copy link
Contributor

Working on this.

@woodser
Copy link
Contributor Author

woodser commented Aug 31, 2023

Ok I've assigned the issue to you @coinstudent2048 :)

@woodser
Copy link
Contributor Author

woodser commented Sep 8, 2023

@coinstudent2048 Checking in if I should merge this as is, or if you are working on adding padding, and also if you are interested in working on bounty issue #673? Another volunteer can help with #673 if you're unavailable.

@coinstudent2048
Copy link
Contributor

coinstudent2048 commented Sep 10, 2023

Hello. Apologies for late reply.

I am not working on adding padding; you can now merge as is.

I will not immediately working on #677, but I'll notify you if I managed to do this.

Thanks!

@woodser
Copy link
Contributor Author

woodser commented Sep 11, 2023

Thanks @coinstudent2048. Please message with a XMR address for payment. Feel free to DM on matrix.

@coinstudent2048
Copy link
Contributor

Hello. I contacted the one with monero.social, because the haveno.exchange one doesn't work for me in Element. Thank you.

@coinstudent2048
Copy link
Contributor

Payment received. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰bounty There is a bounty on this issue good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants