Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tor browser version 14.0.3 and tor binary version: 0.4.8.13 #1534

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

boldsuck
Copy link
Contributor

@boldsuck boldsuck commented Jan 10, 2025

With help from @nahuhh, @preland and @woodser ;-)

Oh, verification-metadata.xml still contains the old hashes from @preland.
Will verification-metadata be rewritten when this is merged or do I have to delete them first?

@boldsuck boldsuck requested a review from woodser as a code owner January 10, 2025 17:50
@woodser
Copy link
Contributor

woodser commented Jan 10, 2025

The update looks good, but the outdated references in verification-metadata.xml can be removed. For example, now there's two tor-binary-windows, tor-binary-macos, tor-binary-linux64, etc.

@boldsuck
Copy link
Contributor Author

boldsuck commented Jan 10, 2025

This looks better. Build works, I tested the .deb.

I think there are ancient things in verification-metadata.xml.
Everything with com.github.bisq-network.tor-binary and com.github.bisq-network.netlayer can probably be deleted too. Has probably stayed there since the renaming: haveno-dex/netlayer@d6fc903

Just checked, even older:

<component group="com.github.bisq-network.netlayer" name="parent" version="0.7.2">
         <artifact name="parent-0.7.2.pom">
            <sha256 value="b79a930b3bc987f1be5821362792b23bb430eb6645b282ca99f4d53a85ef9a6f" origin="Generated by Gradle"/>
         </artifact>
      </component>
      <component group="com.github.bisq-network.netlayer" name="parent" version="6797461310f077bbea4f43a3a509c077b0ed8c34">
         <artifact name="parent-6797461310f077bbea4f43a3a509c077b0ed8c34.pom">
            <sha256 value="d6403c9c26d26ba3ee58f971a5b094522c38ac499940e7181c70e06711ab68f1" origin="Generated by Gradle"/>
         </artifact>
      </component>
      <component group="com.github.bisq-network.netlayer" name="parent" version="8db4a13">
         <artifact name="parent-8db4a13.pom">
            <sha256 value="c0460cf420ac504a3b5349bd91f6a4bba3534ab7be43e2639bb081b032e5e602" origin="Generated by Gradle"/>
         </artifact>

I deleted that and rebuilt Haveno. I can do PR if wanted.

@woodser
Copy link
Contributor

woodser commented Jan 10, 2025

Sure a PR for that would be great. Thanks.

@boldsuck
Copy link
Contributor Author

Github already automatically inserted 3rd commit.
f491ae6

@boldsuck boldsuck mentioned this pull request Jan 11, 2025
@woodser woodser merged commit 533527e into haveno-dex:master Jan 11, 2025
5 checks passed
@woodser
Copy link
Contributor

woodser commented Jan 11, 2025

Nice, thanks. :)

@boldsuck
Copy link
Contributor Author

(A reminder for me) Next tor-binary upgrade nitpiking ToDo:

Rename

  • readme.MD to README.md
  • <groupId>com.github.bisq-network.tor-binary</groupId> to <groupId>com.github.haveno-dex.tor-binary</groupId> in all pom.xml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants