cordyceps: make cursor interface (mostly) match `std` #227

hawkw · 2022-06-18T19:57:23Z

This implements most of the std::collections::linked_list::Cursor, with the following exceptions:

No CursorMut::splice_ methods because I want to implement those separately
No CursorMut::to_cursor methods because we only have a CursorMut type (and adding a Cursor type would be breaking, because it would require renaming Cursor)

Signed-off-by: Eliza Weisman <[email protected]>

This adds `peek_next` and `peek_prev` methods to `cordyceps::list::Cursor`, similar to the methods on `std::collections::linked_list::Cursor`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds a `Cursor::remove_current` method, similar to the one on `std::collections::linked_list::CursorMut`. I also reimplemented `remove_first` to use this. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This adds `Cursor::current` and `Cursor::current_mut` methods, similar to the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds `peek_next` and `peek_prev` methods to `cordyceps::list::Cursor`, similar to the methods on `std::collections::linked_list::Cursor`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This adds a `Cursor::remove_current` method, similar to the one on `std::collections::linked_list::CursorMut`. I also reimplemented `remove_first` to use this. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This renames `List::cursor` to `List::cursor_front_mut` to prepare for adding a `List::cursor_back_mut` and `cursor_front`/`cursor_back`, similarly to `std::collections::LinkedList`'s cursor methods. `List::cursor` is now deprecated. Signed-off-by: Eliza Weisman <[email protected]>

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds `Cursor::insert_before` and `Cursor::insert_after` methods to match the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This replaces the use of `cordyceps::List::cursor` with `cordyceps::List::cursor_front_mut`.

Signed-off-by: Eliza Weisman <[email protected]>

This adds `Cursor::current` and `Cursor::current_mut` methods, similar to the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds `peek_next` and `peek_prev` methods to `cordyceps::list::Cursor`, similar to the methods on `std::collections::linked_list::Cursor`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds a `Cursor::remove_current` method, similar to the one on `std::collections::linked_list::CursorMut`. I also reimplemented `remove_first` to use this. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This renames `List::cursor` to `List::cursor_front_mut` to prepare for adding a `List::cursor_back_mut` and `cursor_front`/`cursor_back`, similarly to `std::collections::LinkedList`'s cursor methods. `List::cursor` is now deprecated. Signed-off-by: Eliza Weisman <[email protected]>

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds `Cursor::insert_before` and `Cursor::insert_after` methods to match the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This renames `List::cursor` to `List::cursor_front_mut` to prepare for adding a `List::cursor_back_mut` and `cursor_front`/`cursor_back`, similarly to `std::collections::LinkedList`'s cursor methods. DEPRECATED: `List::cursor`, renamed to `List::cursor_front_mut`. Signed-off-by: Eliza Weisman <[email protected]>

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds `Cursor::insert_before` and `Cursor::insert_after` methods to match the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This replaces the use of `cordyceps::List::cursor` with `cordyceps::List::cursor_front_mut`.

This renames `List::cursor` to `List::cursor_front_mut` to prepare for adding a `List::cursor_back_mut` and `cursor_front`/`cursor_back`, similarly to `std::collections::LinkedList`'s cursor methods. Deprecates `List::cursor`. DEPRECATED: `List::cursor`, renamed to `List::cursor_front_mut`. Signed-off-by: Eliza Weisman <[email protected]>

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

This adds `Cursor::insert_before` and `Cursor::insert_after` methods to match the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

Signed-off-by: Eliza Weisman <[email protected]>

This replaces the use of `cordyceps::List::cursor` with `cordyceps::List::cursor_front_mut`.

chore(cordyceps): move list::Cursor to its own file (#227)

826f2a4

Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

test(cordyceps): split list tests into modules (#227)

ca5f23f

Signed-off-by: Eliza Weisman <[email protected]>

hawkw force-pushed the eliza/good-cursors branch from 6160ffb to 070633b Compare June 18, 2022 20:06

hawkw added 10 commits June 18, 2022 13:06

feat(cordyceps): add Cursor::current (#227)

b5d2263

This adds `Cursor::current` and `Cursor::current_mut` methods, similar to the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

feat(cordyceps): add Cursor::peek_next/peek_prev (#227)

9b42992

This adds `peek_next` and `peek_prev` methods to `cordyceps::list::Cursor`, similar to the methods on `std::collections::linked_list::Cursor`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

feat(cordyceps): add Cursor::move_next/move_prev

328413a

Signed-off-by: Eliza Weisman <[email protected]>

feat(cordyceps): add Cursor::remove_current (#227)

8c42f85

This adds a `Cursor::remove_current` method, similar to the one on `std::collections::linked_list::CursorMut`. I also reimplemented `remove_first` to use this. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

feat(cordyceps): add Cursor::remove_current (#227)

f356b2a

This adds a `Cursor::remove_current` method, similar to the one on `std::collections::linked_list::CursorMut`. I also reimplemented `remove_first` to use this. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

test(cordyceps): split list tests into modules (#227)

96d14a6

Signed-off-by: Eliza Weisman <[email protected]>

feat(cordyceps): add List::cursor_back_mut (#227)

e53e071

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

feat(cordyceps): add Cursor::index (#227)

b86729e

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

feat(cordyceps): add Cursor::insert_before/after (#227)

52eb1cb

This adds `Cursor::insert_before` and `Cursor::insert_after` methods to match the ones on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

hawkw force-pushed the eliza/good-cursors branch from 070633b to 3a8e20b Compare June 18, 2022 20:10

test(cordyceps): test cleanup (#227)

8f5a2df

Signed-off-by: Eliza Weisman <[email protected]>

hawkw force-pushed the eliza/good-cursors branch from 3a8e20b to 8f5a2df Compare June 18, 2022 20:10

hawkw enabled auto-merge (rebase) June 18, 2022 20:10

fix(maitake): remove use of deprecated API (#227)

a8dc53f

This replaces the use of `cordyceps::List::cursor` with `cordyceps::List::cursor_front_mut`.

hawkw requested a review from jamesmunns June 18, 2022 20:12

hawkw merged commit 7024d6f into main Jun 18, 2022

hawkw deleted the eliza/good-cursors branch June 18, 2022 20:20

hawkw added a commit that referenced this pull request Jun 18, 2022

chore(cordyceps): move list::Cursor to its own file (#227)

9ebedcb

Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

test(cordyceps): split list tests into modules (#227)

1280598

Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

feat(cordyceps): add List::cursor_back_mut (#227)

24faf31

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

feat(cordyceps): add Cursor::index (#227)

bb26fff

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

test(cordyceps): test cleanup (#227)

3a568ee

Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

feat(cordyceps): add List::cursor_back_mut (#227)

77eebba

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

feat(cordyceps): add Cursor::index (#227)

e7585aa

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

test(cordyceps): test cleanup (#227)

dd25830

Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 18, 2022

fix(maitake): remove use of deprecated API (#227)

0473c0f

This replaces the use of `cordyceps::List::cursor` with `cordyceps::List::cursor_front_mut`.

hawkw added a commit that referenced this pull request Jun 21, 2022

feat(cordyceps): add List::cursor_back_mut (#227)

b555204

This adds `List::cursor_back_mut` returning a mutable cursor at the back of the list. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 21, 2022

feat(cordyceps): add Cursor::index (#227)

f5652cd

This adds a `Cursor::index` method to match the one on `std::collections::linked_list::CursorMut`. Closes #224 Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 21, 2022

test(cordyceps): test cleanup (#227)

6e46881

Signed-off-by: Eliza Weisman <[email protected]>

hawkw added a commit that referenced this pull request Jun 21, 2022

fix(maitake): remove use of deprecated API (#227)

f9f4c3d

This replaces the use of `cordyceps::List::cursor` with `cordyceps::List::cursor_front_mut`.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cordyceps: make cursor interface (mostly) match `std` #227

cordyceps: make cursor interface (mostly) match `std` #227

hawkw commented Jun 18, 2022

cordyceps: make cursor interface (mostly) match std #227

cordyceps: make cursor interface (mostly) match std #227

Conversation

hawkw commented Jun 18, 2022

cordyceps: make cursor interface (mostly) match `std` #227

cordyceps: make cursor interface (mostly) match `std` #227