Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary statics calculation on caret movement #1501

Closed
disconcision opened this issue Feb 7, 2025 · 1 comment · Fixed by #1502
Closed

Unnecessary statics calculation on caret movement #1501

disconcision opened this issue Feb 7, 2025 · 1 comment · Fixed by #1502
Labels
bug performance

Comments

@disconcision
Copy link
Member

This is a regression.

caret down action with statics disabled:

Image

caret down action with statics enabled but completion disabled:

Image

caret down action with statics and completion enabled:

Image

Statics should not be recalculated on caret movement (unless there is a new demand for this?) and caret movement should not trigger completion generation, so these profiles should be approximately the same
@cyrus-
Copy link
Member

cyrus- commented Feb 7, 2025

@Negabinary did you consider this in the refactor? may be a pretty small fix?

Negabinary added a commit that referenced this issue Feb 7, 2025
@Negabinary
Fix #1501
2a45a8a
@cyrus- cyrus- mentioned this issue Feb 7, 2025
Merged
Negabinary added a commit that referenced this issue Feb 12, 2025
@Negabinary
Fix #1501
107b31c
@cyrus- cyrus- linked a pull request Feb 12, 2025 that will close this issue
Fix #1501 #1502
Merged
cyrus- added a commit that referenced this issue Feb 12, 2025
@cyrus-
Fix #1501 (#1502)
4759f2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1501 hazelgrove/hazel
2 participants
@cyrus- @disconcision