Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker: parent issues name #2136

Merged
merged 8 commits into from
Jun 27, 2022
Merged

Tracker: parent issues name #2136

merged 8 commits into from
Jun 27, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2022

Contribution checklist

Brief description

Снимок экрана 2022-06-23 в 15 25 47

Снимок экрана 2022-06-23 в 15 25 59

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

closes TSK-128

Sergei Ogorelkov added 4 commits June 23, 2022 16:44
Add "parentNames" property to Issue class
38a1a77 
Signed-off-by: Sergei Ogorelkov <[email protected]>
Add trigger to update parentNames
c809f60 
Signed-off-by: Sergei Ogorelkov <[email protected]>
Block changing parent issue if the issue have a subtasks
f3ba7fb 
Signed-off-by: Sergei Ogorelkov <[email protected]>
Update changelog
ce77469 
Signed-off-by: Sergei Ogorelkov <[email protected]>
@ghost ghost requested review from haiodo and BykhovDenis June 23, 2022 10:24
haiodo
haiodo reviewed Jun 23, 2022
View reviewed changes
models/tracker/src/index.ts Outdated Show resolved Hide resolved
@ghost ghost marked this pull request as draft June 24, 2022 02:53
Sergei Ogorelkov added 2 commits June 24, 2022 17:50
Fix review issues
6786e19 
Signed-off-by: Sergei Ogorelkov <[email protected]>
Merge branch 'main' into parent-issues-name
4877cae 
Signed-off-by: Sergei Ogorelkov <[email protected]>

# Conflicts:
#	changelog.md
@ghost ghost changed the title Parent issues name Tracker: parent issues name Jun 24, 2022
@ghost ghost marked this pull request as ready for review June 24, 2022 10:55
Sergei Ogorelkov added 2 commits June 27, 2022 10:29
Merge branch 'main' into parent-issues-name
9dec756 
Signed-off-by: Sergei Ogorelkov <[email protected]>

# Conflicts:
#	changelog.md
#	plugins/tracker-resources/src/components/SetParentIssueActionPopup.svelte
#	plugins/tracker-resources/src/components/issues/TitlePresenter.svelte
Fix setting parent issue for multiple issues
212347b 
Signed-off-by: Sergei Ogorelkov <[email protected]>
@haiodo haiodo merged commit 6f0bd0a into main Jun 27, 2022
@haiodo haiodo deleted the parent-issues-name branch June 27, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haiodo