Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-791: Handle department's public holidays + add stats for it #2735

Merged
merged 4 commits into from
Mar 16, 2023
Merged

TSK-791: Handle department's public holidays + add stats for it #2735

merged 4 commits into from
Mar 16, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Mar 15, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-791
image
image

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR ThetaDR requested review from haiodo and BykhovDenis March 15, 2023 09:30
haiodo
haiodo reviewed Mar 15, 2023
View reviewed changes
plugins/hr-resources/src/components/ScheduleView.svelte Outdated
/>
{:else if display === 'stats'}
<MonthTableView {departmentStaff} {employeeRequests} {types} {currentDate} {timeReports} {holidays} />
{#await getDepartmentsForEmployee() then result}
Copy link
Member

@haiodo haiodo Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid '#'await if possible

@haiodo haiodo merged commit 6c18d7e into main Mar 16, 2023
@haiodo haiodo deleted the TSK-791 branch March 16, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo