Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-476: Duplicate comment fix #3425

Merged
merged 2 commits into from
Jun 12, 2023
Merged

UBER-476: Duplicate comment fix #3425

merged 2 commits into from
Jun 12, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Jun 12, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

haiodo added 2 commits June 12, 2023 18:23
@haiodo
UBER-476: Fix comment doubling
fd0a75c 
Signed-off-by: Andrey Sobolev <[email protected]>
@haiodo
Duplicate comment fix tool
3dfd46b 
Signed-off-by: Andrey Sobolev <[email protected]>
@haiodo haiodo requested a review from ThetaDR June 12, 2023 11:27
@haiodo haiodo changed the title UBER-476 UBER-476: Duplicate comment fix Jun 12, 2023
@haiodo haiodo merged commit 14b7806 into main Jun 12, 2023
@haiodo haiodo deleted the UBER-476 branch June 12, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThetaDR ThetaDR ThetaDR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @ThetaDR