Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity: remove inline from presenters. DoneStatesPopup fix. #3664

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

SasLord
Copy link
Member

@SasLord SasLord commented Sep 6, 2023

Contribution checklist

Brief description

Снимок экрана 2023-09-06 в 11 10 59 Снимок экрана 2023-09-06 в 11 06 12 Снимок экрана 2023-09-06 в 11 41 40 Снимок экрана 2023-09-06 в 11 06 47

Comment + activity presenters:

Снимок экрана 2023-09-06 в 11 44 50

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@SasLord SasLord requested review from haiodo and aplatoff September 6, 2023 08:43
@haiodo haiodo merged commit d7fa8c3 into main Sep 6, 2023
@haiodo haiodo deleted the remove-inline-in-activity branch September 6, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants