-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBERF-4195: fix query after applying viewOptions #3942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break viewOptions, can you give an example? (If it necessary we should find another way to fix it, probably we need method in core to merge queries)
@BykhovDenis long story short. It replaces spaces that we are using in filter with spaces from viewOptions (for non-archive) More info:
So it will override spaces (vac1 and vac2) with spaces that are not archived (vac1 and vac3) |
Signed-off-by: Vyacheslav Tumanov <[email protected]>
Signed-off-by: Vyacheslav Tumanov <[email protected]>
@BykhovDenis PTAL, made a function for queries merging |
…redicate Signed-off-by: Vyacheslav Tumanov <[email protected]>
Signed-off-by: Vyacheslav Tumanov <[email protected]>
Signed-off-by: Vyacheslav Tumanov <[email protected]>
Contribution checklist
Brief description
Checklist
Related issues
A list of closed updated issues