Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-4195: fix query after applying viewOptions #3942

Merged
merged 5 commits into from
Nov 10, 2023
Merged

UBERF-4195: fix query after applying viewOptions #3942

merged 5 commits into from
Nov 10, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Nov 6, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR ThetaDR requested a review from haiodo November 6, 2023 12:48
Copy link
Member

@BykhovDenis BykhovDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break viewOptions, can you give an example? (If it necessary we should find another way to fix it, probably we need method in core to merge queries)

@ThetaDR
Copy link
Contributor Author

ThetaDR commented Nov 6, 2023

@BykhovDenis long story short. It replaces spaces that we are using in filter with spaces from viewOptions (for non-archive)

More info:

  1. Company1 has two vacancies (vac1 and vac2)
    Company2 has vac3
  2. All of them have applicants
  3. Vac1 is archived
  4. User is trying to filter applicants via vacancy with company == Company1. And viewOption for hiding archived vacancies is on.

So it will override spaces (vac1 and vac2) with spaces that are not archived (vac1 and vac3)

@ThetaDR
Copy link
Contributor Author

ThetaDR commented Nov 7, 2023

@BykhovDenis PTAL, made a function for queries merging

packages/core/src/utils.ts Outdated Show resolved Hide resolved
@ThetaDR ThetaDR requested a review from haiodo November 8, 2023 11:49
packages/core/src/utils.ts Outdated Show resolved Hide resolved
Signed-off-by: Vyacheslav Tumanov <[email protected]>
@haiodo haiodo merged commit f8cdaba into main Nov 10, 2023
7 checks passed
@haiodo haiodo deleted the UBERF-4195 branch November 10, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants