Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZQMS-377: Add file attachments extension to text editor #4284

Merged
merged 9 commits into from
Mar 7, 2024

Conversation

bellycat77
Copy link
Contributor

@bellycat77 bellycat77 commented Dec 28, 2023

Contribution checklist

Brief description

Screenshot 2023-12-29 at 12 21 37
  • The attachment should be displayed "inline" as a part of the section.
  • It should be possible to download any of the files.
  • It should be possible to remove any of the files from the document.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svele-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

@bellycat77 bellycat77 requested a review from aonnikov December 29, 2023 08:38
@bellycat77 bellycat77 marked this pull request as ready for review January 9, 2024 12:45
@aonnikov aonnikov closed this Jan 22, 2024
@aonnikov aonnikov reopened this Jan 22, 2024
@aonnikov aonnikov force-pushed the add-file-attachments-extension branch from 7da841c to 0a480c2 Compare March 7, 2024 07:02
@aonnikov aonnikov force-pushed the add-file-attachments-extension branch from 0a480c2 to 523dd8d Compare March 7, 2024 07:23
aonnikov
aonnikov previously approved these changes Mar 7, 2024
Signed-off-by: Alexander Onnikov <[email protected]>
@aonnikov aonnikov merged commit 9ef5b8f into main Mar 7, 2024
7 checks passed
@aonnikov aonnikov deleted the add-file-attachments-extension branch March 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants