Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-8357: Remove node fetch from some services #6812

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

lexiv0re
Copy link
Collaborator

@lexiv0re lexiv0re commented Oct 4, 2024

  • Uses native nodejs fetch in some of the existing services

Note: After this PR It's still used in datalake client and it appeared not to be a trivial task to switch to the native modules there as it uses streams for uploading files and it involves using some experimental apis to support similar functions on the native modules so I felt like it's not worth it for now.

Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-8357

Huly®: UBERF-8360

@lexiv0re lexiv0re requested a review from haiodo October 4, 2024 13:57
@haiodo haiodo merged commit bb96ae4 into develop Oct 4, 2024
8 of 10 checks passed
@haiodo haiodo deleted the uberf-8357/remove-node-fetch branch October 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants