Matches all docs if bf (Boost Function) present

[janhoy]

If your edismax query involves bf parameter, and the query matches a synonym, this plugin seems to generate a query which always returns all documents. Simply adding e.g. bf=last_modified to any of the unit tests will reveal the bug. The constructed parsed-query looks something like this (assuming query restskatt being expanded with synonym baksmell, and bf=SearchRank^10:

(
  DisjunctionMaxQuery(((PageName:restskatt)^30.0))^1.0 
  ((+DisjunctionMaxQuery(((PageName:baksmell)^30.0)))/no_coord^1.0)
) 
FunctionQuery(float(SearchRank))^10.0"

[Mykezero]

Yeah, I've been having this problem as well with Solr 6.0 and the 5.0.4 version of the plugin; I wasn't sure what was causing it. Thanks for working on this @janhoy !

[janhoy]

Would you have a chance to test my PR and see if it works for you? If so, I'll commit it..

[Mykezero]

Absolutely. I'll check it out tomorrow morning and give it a test run.

[Mykezero]

Everything seems to be working correctly. I haven't come across any query yet that throws it off. I think it may be good to go!

[Mykezero]

Thanks @janhoy for the work you put into this. I really appreciate it! 😺