Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

Add JRuby to travis-ci #6

Closed
nadavshatz opened this issue Mar 21, 2016 · 2 comments
Closed

Add JRuby to travis-ci #6

nadavshatz opened this issue Mar 21, 2016 · 2 comments
Assignees

Comments

@nadavshatz
Copy link

Hi, We're using Heap for a while now but our stack uses JRuby.
I think it'll be beneficial to add JRuby to the Travis CI tests.

Let me know if you need it and I can try and get a PR for it as well.

@pwnall
Copy link
Contributor

pwnall commented Mar 21, 2016

@nadavshatz Do you happen to use Travis for your own projects as well? If so, can you please tell me what rvm values you use?

I created PR #8 that adds jruby-18mode and jruby-19mode to the test matrix, but that only seems to cover JRuby 1.7. These tags seem very under-specified, compared to the ones related to MRI.

Thanks!

@pwnall pwnall self-assigned this Mar 21, 2016
@nadavshatz
Copy link
Author

I've actually added some of this on another repo that can give you some more reference.
Here's the PR: rails-api/active_model_serializers#1496

Beyond that, I would highly recommend adding the newer Jruby's that are ruby 2+ compatible.

Another thing you can do which will make it easier for you guys is to not support the same ruby versions on jruby and mri and say so in the Readme - basically support jruby 9+/1.7+ only.

Let me know if I can assist in any other way and cheers for the new gem!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants