Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max FPS Slider only goes to 239 #810

Closed
smiRaphi opened this issue Mar 3, 2025 · 15 comments · Fixed by #1082
Closed

Max FPS Slider only goes to 239 #810

smiRaphi opened this issue Mar 3, 2025 · 15 comments · Fixed by #1082
Labels
video option Issue caused by the toggles on the Video tab of the Options Menu
Milestone

Comments

@smiRaphi
Copy link

smiRaphi commented Mar 3, 2025

I would like to set the fps to my monitors refresh rate without vsync but the fps slider only goes to 239 and from there to max, there isn't a single monitor with a refresh rate of 239hz, please make it extend to 240 before going to max

@hyperbx
Copy link
Member

hyperbx commented Mar 3, 2025

Setting the FPS slider to MAX uncaps the frame rate.

@smiRaphi
Copy link
Author

smiRaphi commented Mar 3, 2025

Yes I know but I want to set it to 240 and not unlocked

@hyperbx
Copy link
Member

hyperbx commented Mar 3, 2025

If your refresh rate is 240Hz, you can use V-Sync with an uncapped frame rate.

@smiRaphi
Copy link
Author

smiRaphi commented Mar 3, 2025

That's what I'm currently doing but I'd like to do it without V-Sync, besides that, there is no point in having the slider only go up to 239

@hyperbx
Copy link
Member

hyperbx commented Mar 3, 2025

What is the reason for needing V-Sync off in this use case?

@smiRaphi
Copy link
Author

smiRaphi commented Mar 3, 2025

With V-Sync off I'm getting around 270 to 300fps in the town area but with it on it sometimes drops to around 190

@hyperbx
Copy link
Member

hyperbx commented Mar 3, 2025

Are you using a third-party profiler to check the frame rate (e.g. RivaTuner)? We have a profiler built-in if you press F1. That should give you more accurate metrics without doing any injection that could potentially also cause FPS drops.

@smiRaphi
Copy link
Author

smiRaphi commented Mar 3, 2025

Checked with the built in one and it's still sometimes dropping to around 200 there and more often runs at 230ish

@DeaTh-G DeaTh-G added the video option Issue caused by the toggles on the Video tab of the Options Menu label Mar 3, 2025
@blueskythlikesclouds
Copy link
Member

As a solution I can make 241 FPS act as the MAX value and let you lock your frame rate to 240.

@smiRaphi
Copy link
Author

smiRaphi commented Mar 3, 2025

Yep, that sounds good

@Calinou
Copy link

Calinou commented Mar 4, 2025

In general, I consider it a best practice for FPS cap sliders to allow any value up to 1000, so it covers future monitors that will go up to 1,000 Hz (prototypes have already been demonstrated). When you can set a max FPS value of 1000, there's not much point in allowing a true unlimited value.

Unfortunately, it's not great in terms of gamepad usability unless you have slider acceleration built-in (where holding the left stick/D-pad for a while scrolls through values faster over time).

@DeaTh-G DeaTh-G added this to the v1.0.2 milestone Mar 4, 2025
@Rekt3y
Copy link

Rekt3y commented Mar 4, 2025

Unfortunately, it's not great in terms of gamepad usability unless you have slider acceleration built-in (where holding the left stick/D-pad for a while scrolls through values faster over time).

We are on PC after all, a text input could work alongside the slider input maybe?

@Calinou
Copy link

Calinou commented Mar 5, 2025

We are on PC after all, a text input could work alongside the slider input maybe?

That could work if the slider uses larger increments while using a gamepad.

@BlueSpeedsterYT
Copy link

If I can throw in my two cents into this, I feel like the FPS Slider should at least cap up until the rounded number of the Display's Refresh rate, with a future cap to around 1000 FPS like what @Calinou said.
It would, of course, need some testing to make sure something like that would even work without it causing any issues but it would be very helpful to see what other FPS issues can occur, among other things.

@Squiddu
Copy link

Squiddu commented Mar 6, 2025

Also in a case like mine, using V-Sync isn't really feasible because for whatever reason, having it on actually causes some screen tearing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
video option Issue caused by the toggles on the Video tab of the Options Menu
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants