Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seq module scope #306

Closed
TysonMN opened this issue Feb 7, 2021 · 1 comment · Fixed by #307
Closed

Seq module scope #306

TysonMN opened this issue Feb 7, 2021 · 1 comment · Fixed by #307
Milestone

Comments

@TysonMN
Copy link
Member

TysonMN commented Feb 7, 2021

I would prefer if the Seq module had internal scope. Currently it has public scope.

module Seq =
let cons (x : 'a) (xs : seq<'a>) : seq<'a> =
seq {
yield x
yield! xs
}
let consNub (x : 'a) (ys0 : seq<'a>) : seq<'a> =
match Seq.tryHead ys0 with
| None -> Seq.singleton x
| Some y ->
if x = y then
ys0
else
cons x ys0

@moodmosaic
Copy link
Member

moodmosaic commented Feb 7, 2021

Yes, it ought to be internal. I can't remember why we've declared it as public. Feel free to change it to internal.

(Besides that I can't remember why it's public, I also can't find a reason for having it public. So, internal would be better.)

@ghost ghost closed this as completed in #307 Feb 7, 2021
@ghost ghost added this to the 0.11.0 milestone Feb 7, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants