4.x: CDI bridge for service registry + config factory improvements #9845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
This uncovered a problem with the CDI bridge, where we may add duplicate beans to CDI. I will resolve the problem asap. |
Reduce weight of the config factory, so it can be easily overridden Fix error in javadoc of GlobalConfig Update test to validate the new feature
- updated service registry extension to fix a few discovered issues
tomas-langer
force-pushed
the
inject-config-improvements
branch
from
1bc58aa to
ff7d85e
Compare
tomas-langer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9849
Description
Add support for injection of io.helidon.config.Config
Reduce weight of the config factory, so it can be easily overridden
Fix error in javadoc of GlobalConfig
Update test to validate the change