Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth recovery from invalid configs #12338

Closed
nik-rev opened this issue Dec 25, 2024 · 0 comments
Closed

Smooth recovery from invalid configs #12338

nik-rev opened this issue Dec 25, 2024 · 0 comments
Labels
C-enhancement Category: Improvements

Comments

@nik-rev
Copy link
Contributor

nik-rev commented Dec 25, 2024

If you have an invalid config key, your entire config will be disabled

But this can be really annoying for people who have custom PRs merged into their personal forks. I currently have #11285 merged and have the following config set:

[keys.normal.space]
E = "file_browser"

But since this is only valid in that PR and not on master, everytime I try to use a different branch that doesn't have my config my entire setup stops working:

image

So what I usually do is comment out that part of config every time. Since I have quite a lot of branches for Helix, and test various things out time to time, this ends up being a common procedure

Imo, it would be better for user experience if you still got the Bad config warning and forced to press enter, but at least your other settings should continue to work.

@nik-rev nik-rev added the C-enhancement Category: Improvements label Dec 25, 2024
@helix-editor helix-editor locked and limited conversation to collaborators Dec 25, 2024
@the-mikedavis the-mikedavis converted this issue into discussion #12342 Dec 25, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

1 participant