From 85d1c490d5cb9068ca5258314fe9f6e843e87568 Mon Sep 17 00:00:00 2001 From: Christopher Zell Date: Thu, 10 Feb 2022 15:42:51 +0100 Subject: [PATCH] fix: add unit to extra arg help message The help message for the --helm-extra-args config used an example without units, which caused to fail the next chart-testing run if just copy-pasted. Signed-off-by: Christopher Zell --- ct/cmd/install.go | 2 +- doc/ct_install.md | 2 +- doc/ct_lint-and-install.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ct/cmd/install.go b/ct/cmd/install.go index 23968781..be16d8d6 100644 --- a/ct/cmd/install.go +++ b/ct/cmd/install.go @@ -63,7 +63,7 @@ func addInstallFlags(flags *flag.FlagSet) { the ID of a pull request. If not specified, the name of the chart is used`)) flags.String("helm-extra-args", "", heredoc.Doc(` Additional arguments for Helm. Must be passed as a single quoted string - (e.g. "--timeout 500"`)) + (e.g. "--timeout 500s"`)) flags.Bool("upgrade", false, heredoc.Doc(` Whether to test an in-place upgrade of each chart from its previous revision if the current version should not introduce a breaking change according to the SemVer spec`)) diff --git a/doc/ct_install.md b/doc/ct_install.md index 55c9c019..271a9e8e 100644 --- a/doc/ct_install.md +++ b/doc/ct_install.md @@ -49,7 +49,7 @@ ct install [flags] --excluded-charts strings Charts that should be skipped. May be specified multiple times or separate values with commas --helm-extra-args string Additional arguments for Helm. Must be passed as a single quoted string - (e.g. "--timeout 500" + (e.g. "--timeout 500s" --helm-repo-extra-args strings Additional arguments for the 'helm repo add' command to be specified on a per-repo basis with an equals sign as delimiter (e.g. 'myrepo=--username test --password secret'). May be specified diff --git a/doc/ct_lint-and-install.md b/doc/ct_lint-and-install.md index 4e67e46d..2216a9fb 100644 --- a/doc/ct_lint-and-install.md +++ b/doc/ct_lint-and-install.md @@ -41,7 +41,7 @@ ct lint-and-install [flags] --excluded-charts strings Charts that should be skipped. May be specified multiple times or separate values with commas --helm-extra-args string Additional arguments for Helm. Must be passed as a single quoted string - (e.g. "--timeout 500" + (e.g. "--timeout 500s" --helm-repo-extra-args strings Additional arguments for the 'helm repo add' command to be specified on a per-repo basis with an equals sign as delimiter (e.g. 'myrepo=--username test --password secret'). May be specified