Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/ambassador]better control for namespace scope #12669

Closed
ryandawsonuk opened this issue Mar 29, 2019 · 0 comments · Fixed by #12670
Closed

[stable/ambassador]better control for namespace scope #12669

ryandawsonuk opened this issue Mar 29, 2019 · 0 comments · Fixed by #12670

Comments

@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented Mar 29, 2019

Currently you can set env.AMBASSADOR_SINGLE_NAMESPACE to tell ambassador to only watch resources in the current namespace. But if you have a chain of dependent charts then once one turns this on then you can't turn it off again. This is because ambassador expects the var to either be set or not set and unsetting a value in a map is problematic.

It would be smoother to make this its own variable wrapped in an if statement, as it used to be at some point.

For other env vars it is fine to use the env map but this one is better handled by wrapping in an if statement as ambassador works by looking at whether it is set or not set, not by looking at the value of the var

@ryandawsonuk ryandawsonuk changed the title [stable/ambassador]better control for namespace [stable/ambassador]better control for namespace scope Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant