From 2f36ecf0262d418c98c6f560d4deb15731624a84 Mon Sep 17 00:00:00 2001 From: zero734kr Date: Thu, 1 Apr 2021 18:22:38 -0300 Subject: [PATCH 1/6] fix(PetitioResponse): fixed that non-alphabetic letters was being broken --- src/lib/PetitioResponse.ts | 2 +- tests/checkKorean.test.ts | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 tests/checkKorean.test.ts diff --git a/src/lib/PetitioResponse.ts b/src/lib/PetitioResponse.ts index 8f77c0f..ec62087 100644 --- a/src/lib/PetitioResponse.ts +++ b/src/lib/PetitioResponse.ts @@ -59,7 +59,7 @@ export class PetitioResponse { * @return {*} A serialized object result parsed from the response body. */ public json(): T { - return JSON.parse(String.fromCharCode(...this.body.toJSON().data)); + return JSON.parse(this.body.toString()); } /** diff --git a/tests/checkKorean.test.ts b/tests/checkKorean.test.ts new file mode 100644 index 0000000..41cba46 --- /dev/null +++ b/tests/checkKorean.test.ts @@ -0,0 +1,12 @@ + +import fetch from "../src"; + +describe("check korean", () => { + test("SHOULD not crash while parsing korean", async () => { + const URL = "https://ludy.game.onstove.com:44333/web/ItemDictionary/Select/212300022?_=1617310085179"; + + const res = await fetch(URL).json(); + + expect(res.ItemInfo.BasicInfo.itemName).toBe("타락한 그림자의 반지"); + }); +}); From 21cbac8cdb84e1447323f86daa7355bccbe91662 Mon Sep 17 00:00:00 2001 From: zero734kr Date: Thu, 1 Apr 2021 18:40:57 -0300 Subject: [PATCH 2/6] fix: delete korean test file --- tests/checkKorean.test.ts | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 tests/checkKorean.test.ts diff --git a/tests/checkKorean.test.ts b/tests/checkKorean.test.ts deleted file mode 100644 index 41cba46..0000000 --- a/tests/checkKorean.test.ts +++ /dev/null @@ -1,12 +0,0 @@ - -import fetch from "../src"; - -describe("check korean", () => { - test("SHOULD not crash while parsing korean", async () => { - const URL = "https://ludy.game.onstove.com:44333/web/ItemDictionary/Select/212300022?_=1617310085179"; - - const res = await fetch(URL).json(); - - expect(res.ItemInfo.BasicInfo.itemName).toBe("타락한 그림자의 반지"); - }); -}); From 8e5676ba395e06fc2d08c7bd3bae56480a275b90 Mon Sep 17 00:00:00 2001 From: zero734kr Date: Thu, 1 Apr 2021 18:43:55 -0300 Subject: [PATCH 3/6] fix: add encoding option as PetitioResponse#text --- src/lib/PetitioResponse.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lib/PetitioResponse.ts b/src/lib/PetitioResponse.ts index ec62087..3d5f467 100644 --- a/src/lib/PetitioResponse.ts +++ b/src/lib/PetitioResponse.ts @@ -56,10 +56,11 @@ export class PetitioResponse { /** * @template T Type casting parameter for the JSON result. + * @param {BufferEncoding} [encoding="utf8"] The encoding to use before parsing to json. * @return {*} A serialized object result parsed from the response body. */ - public json(): T { - return JSON.parse(this.body.toString()); + public json(encoding: BufferEncoding = "utf8"): T { + return JSON.parse(this.body.toString(encoding)); } /** From 2b5ff8d9cacea827f5abe5b9762e33a6943f1f70 Mon Sep 17 00:00:00 2001 From: zero734kr Date: Thu, 1 Apr 2021 19:51:50 -0300 Subject: [PATCH 4/6] =?UTF-8?q?chore:=20change=20wording=20to=20=E2=80=9Cf?= =?UTF-8?q?ormatting=E2=80=9D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/lib/PetitioResponse.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/PetitioResponse.ts b/src/lib/PetitioResponse.ts index 3d5f467..a736e01 100644 --- a/src/lib/PetitioResponse.ts +++ b/src/lib/PetitioResponse.ts @@ -56,7 +56,7 @@ export class PetitioResponse { /** * @template T Type casting parameter for the JSON result. - * @param {BufferEncoding} [encoding="utf8"] The encoding to use before parsing to json. + * @param {BufferEncoding} [encoding="utf8"] The encoding to use before formatting to json. * @return {*} A serialized object result parsed from the response body. */ public json(encoding: BufferEncoding = "utf8"): T { From ad09d6b3685b91280954e2f7acd3b0605fe073e9 Mon Sep 17 00:00:00 2001 From: Nytelife26 Date: Fri, 2 Apr 2021 18:27:52 +0100 Subject: [PATCH 5/6] style: fix indentation in pr --- src/lib/PetitioResponse.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/PetitioResponse.ts b/src/lib/PetitioResponse.ts index a736e01..4c6c181 100644 --- a/src/lib/PetitioResponse.ts +++ b/src/lib/PetitioResponse.ts @@ -56,7 +56,7 @@ export class PetitioResponse { /** * @template T Type casting parameter for the JSON result. - * @param {BufferEncoding} [encoding="utf8"] The encoding to use before formatting to json. + * @param {BufferEncoding} [encoding="utf8"] The encoding to use before formatting to json. * @return {*} A serialized object result parsed from the response body. */ public json(encoding: BufferEncoding = "utf8"): T { From f5c22f45e8f1a60b702183cfcec6cf3174a6388d Mon Sep 17 00:00:00 2001 From: Nytelife26 Date: Fri, 2 Apr 2021 18:47:54 +0100 Subject: [PATCH 6/6] docs(PetitioResponse): make json documentation consistent --- src/lib/PetitioResponse.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/PetitioResponse.ts b/src/lib/PetitioResponse.ts index 4c6c181..5f7f31b 100644 --- a/src/lib/PetitioResponse.ts +++ b/src/lib/PetitioResponse.ts @@ -56,8 +56,8 @@ export class PetitioResponse { /** * @template T Type casting parameter for the JSON result. - * @param {BufferEncoding} [encoding="utf8"] The encoding to use before formatting to json. - * @return {*} A serialized object result parsed from the response body. + * @param {BufferEncoding} [encoding="utf8"] The encoding to use when parsing the response body. + * @return {T} A serialized object result parsed from the response body. */ public json(encoding: BufferEncoding = "utf8"): T { return JSON.parse(this.body.toString(encoding));