From bbd3710b4bf9fdbd7a28fc46dc2393a86909500a Mon Sep 17 00:00:00 2001 From: Kevin Brolly Date: Thu, 14 May 2020 19:57:54 +0100 Subject: [PATCH 1/2] Use os.tmpdir() rather than /tmp for cross-platform support --- packages/addons-v5/commands/addons/open.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/addons-v5/commands/addons/open.js b/packages/addons-v5/commands/addons/open.js index 5f97116310..4b1d14c2a0 100644 --- a/packages/addons-v5/commands/addons/open.js +++ b/packages/addons-v5/commands/addons/open.js @@ -3,13 +3,14 @@ let cli = require('heroku-cli-util') let co = require('co') let fs = require('fs') +let os = require('os') function open (url) { cli.log(`Opening ${cli.color.cyan(url)}...`) return cli.open(url) } -const ssoPath = '/tmp/heroku-sso.html' +const ssoPath = os.tmpdir() + '/heroku-sso.html' function writeSudoTemplate (ctx, sso, path) { return new Promise(function (resolve, reject) { From 102cf6ba0794de48c8f936ac4e67a4e6b6b9276a Mon Sep 17 00:00:00 2001 From: Kevin Brolly Date: Fri, 15 May 2020 16:34:57 +0100 Subject: [PATCH 2/2] Ensure ssoPath uses cross-platform path seperators --- packages/addons-v5/commands/addons/open.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/addons-v5/commands/addons/open.js b/packages/addons-v5/commands/addons/open.js index 4b1d14c2a0..c32f587e20 100644 --- a/packages/addons-v5/commands/addons/open.js +++ b/packages/addons-v5/commands/addons/open.js @@ -4,13 +4,14 @@ let cli = require('heroku-cli-util') let co = require('co') let fs = require('fs') let os = require('os') +let path = require('path') function open (url) { cli.log(`Opening ${cli.color.cyan(url)}...`) return cli.open(url) } -const ssoPath = os.tmpdir() + '/heroku-sso.html' +const ssoPath = path.join(os.tmpdir(), 'heroku-sso.html') function writeSudoTemplate (ctx, sso, path) { return new Promise(function (resolve, reject) {