Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Tooltip shouldBlockScroll doesn't work #3474

Closed
yevhenzar opened this issue Jul 15, 2024 · 6 comments · Fixed by #3307 or #4539
Closed

[BUG] - Tooltip shouldBlockScroll doesn't work #3474

yevhenzar opened this issue Jul 15, 2024 · 6 comments · Fixed by #3307 or #4539
Assignees
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working

Comments

@yevhenzar
Copy link

yevhenzar commented Jul 15, 2024

NextUI Version

2.4.2

Describe the bug

Tooltip's prop shouldBlockScroll doesn't work as intended, scroll is not blocked and I can still scroll content below tooltip

Your Example Website or App

https://codesandbox.io/p/devbox/great-haslett-83r6xg?workspaceId=3d68e848-d3a4-4835-979a-3a4880722b13

Steps to Reproduce the Bug or Issue

You can check this behaviour on sandbox, I've attached

Expected behavior

When i pass shouldBlockScroll={true} to Tooltip component, it should block scroll below. As it works in Dropdown component, for example

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

Copy link

linear bot commented Jul 15, 2024

@wingkwong
Copy link
Member

Seems the entire logic is missing

@wingkwong wingkwong added 🐛 Type: Bug Something isn't working 📦 Scope : Components Related to the components labels Jul 15, 2024
@awesome-pro
Copy link
Contributor

awesome-pro commented Jul 15, 2024

@yevhenzar I believe first you should retry after correcting the props, there is no such prop in tooltip
Screenshot 2024-07-15 at 8 40 21 PM

@wingkwong
Copy link
Member

@abhinandan-verma I tried already.

@wingkwong
Copy link
Member

wingkwong commented Sep 14, 2024

reopening - the PR involves breaking change. will reschedule the release in v2.5.0.

@ryo-manba
Copy link
Member

It's unnatural for a tooltip that appears on hover to lock scrolling, so we plan to prevent it from accepting props in the following PR. #4539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working
Projects
None yet
4 participants