Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Listbox Item href causes full reload (regression) #3784

Closed
TheCodeDestroyer opened this issue Sep 19, 2024 · 7 comments · Fixed by #3732
Closed

[BUG] - Listbox Item href causes full reload (regression) #3784

TheCodeDestroyer opened this issue Sep 19, 2024 · 7 comments · Fixed by #3732
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working

Comments

@TheCodeDestroyer
Copy link

TheCodeDestroyer commented Sep 19, 2024

NextUI Version

2.4.8

Describe the bug

When navigating via Listbox it causes full page reload.
This seemed to be an issue in v2.4.0, but supposedly was fixed in "@nextui-org/link": "0.0.0-canary-20240529193819".
Initial issue: #3105

Your Example Website or App

https://codesandbox.io/p/devbox/nextjs-ui-46j3v2

Steps to Reproduce the Bug or Issue

You can clearly see that the links on the left (using listbox) reload the whole page, while the links on left (using Link) only do it clientside

Expected behavior

As a user I want the ListboxItem links to properly use client side navigation if NextUIProvider is properly defined

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

@wingkwong
Copy link
Member

suggest to revisit after RA version bump. I think there's something changed internally on their side.

@TheCodeDestroyer
Copy link
Author

suggest to revisit after RA version bump. I think there's something changed internally on their side.

@wingkwong pardon my ignorance, but which lib is RA?

@wingkwong
Copy link
Member

React Aria. NextUI is built on top of it.

@wingkwong wingkwong added 🐛 Type: Bug Something isn't working 📦 Scope : Components Related to the components labels Sep 23, 2024
@hardchor
Copy link

hardchor commented Sep 27, 2024

Updating @react-aria/utils to 3.25.2 fixed it for me.

My package.json:

{
...
  "resolutions": {
    "@react-aria/utils": "^3.25.2"
  },
}

NB: This might be a yarn-specific feature, check how to override transitive dependencies in your favourite package manager (e.g. overrides in npm)

@ayanamists
Copy link

Updating @react-aria/utils to 3.25.2 fixed it for me.

My package.json:

{
...
  "resolutions": {
    "@react-aria/utils": "^3.25.2"
  },
}

NB: This might be a yarn-specific feature, check how to override transitive dependencies in your favourite package manager (e.g. overrides in npm)

Seems not work for me

@abonoit
Copy link

abonoit commented Nov 6, 2024

Seems not work for me

Same thing here, an href on a ListboxItem keeps reloading the page.
I'm on the latest react-aria version

@caish-cloud-admin
Copy link

"resolutions": {
"@react-aria/utils": "^3.25.2"
},

This worked for me. I used 3.26.0 since that is the newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants