Add validation helper for Label Values/Keys #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is similar to the implementation in the hcloud-go. To give the "user" as much as verbosity as possible i introduced two methods. - `validate` which is a simple validator that just returns True/False.add-validator-for-labels - `validate_verbose` which also returns the corresponding error message (like which key/value is not correctly formatted) I decided against calling one of both function in the other and instead duplicate the code. This is based on my feeling that the code would be more complex when we as a sample call validate_verbose in validate. Also, it is slightly more readable imho, but we can discuss this :) Closes #153 Signed-off-by: Lukas Kämmerling <[email protected]>
Signed-off-by: Lukas Kämmerling <[email protected]>
LKaemmerling
force-pushed
the
add-validator-for-labels
branch
from
2457212 to
62dcc7d
Compare
4ND3R50N
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is similar to the implementation in the hcloud-go. To give the "user" as much as verbosity as possible i introduced two methods.
validatewhich is a simple validator that just returns True/Falsevalidate_verbosewhich also returns the corresponding error message (like which key/value is not correctly formatted)I decided against calling one of both function in the other and instead duplicate the code. This is based on my feeling that the code would be more complex when we as a sample call validate_verbose in validate. Also, it is slightly more readable imho, but we can discuss this :)
Closes #153
Signed-off-by: Lukas Kämmerling [email protected]