From 571674608bb099c2ce01952816f606e6781dd475 Mon Sep 17 00:00:00 2001
From: Fred Emmott <fe@fb.com>
Date: Mon, 28 Mar 2016 14:09:55 -0700
Subject: [PATCH] Change contenteditable and draggable from bool to enum {
 "true", "false" }

fixes #155
---
 src/html/Element.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/html/Element.php b/src/html/Element.php
index ffa93cfe..03e27d93 100644
--- a/src/html/Element.php
+++ b/src/html/Element.php
@@ -18,14 +18,19 @@
 abstract class :xhp:html-element extends :x:primitive {
   use XHPBaseHTMLHelpers;
 
+  // enum { 'true', 'false' } attributes: these are actually tri-state -
+  // the implied third value is usually 'auto' or 'inherit'; for example,
+  // contenteditable defaults to 'inherit' if unspecified, so
+  // contenteditable=false is valid ans has meaning
+
   attribute
     // Global HTML attributes
     Stringish accesskey,
     Stringish class,
-    bool contenteditable,
+    enum { 'true', 'false' } contenteditable,
     Stringish contextmenu,
     Stringish dir,
-    bool draggable,
+    enum { 'true', 'false' } draggable,
     Stringish dropzone,
     bool hidden,
     Stringish id,