From 360d0522e3ed5f992c37b1d8b2314af3af9a26c8 Mon Sep 17 00:00:00 2001
From: wdg <2515717245@qq.com>
Date: Sat, 12 Feb 2022 08:29:24 +0800
Subject: [PATCH] =?UTF-8?q?=E5=A2=9E=E5=8A=A0=E4=B8=8B=E8=BD=BD=E7=9A=84?=
 =?UTF-8?q?=E6=9D=83=E9=99=90(hhyo#1367)=20(#1369)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* 增加下载的权限(hhyo#1367)

* 修复拼写错误

* 补加SQL文件

* 变量名修改以及其他优化

* 权限名修改
---
 sql/models.py               | 1 +
 sql/templates/group.html    | 2 +-
 sql/templates/sqlquery.html | 6 ++++--
 sql/views.py                | 6 +++---
 src/init_sql/v1.8.3.sql     | 7 ++++++-
 5 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/sql/models.py b/sql/models.py
index 552d24c505..4d6a2c0f16 100755
--- a/sql/models.py
+++ b/sql/models.py
@@ -730,6 +730,7 @@ class Meta:
             ('archive_review', '审核归档申请'),
             ('archive_mgt', '管理归档申请'),
             ('audit_user','审计权限'),
+            ('query_download', '在线查询下载权限'),
         )
 
 
diff --git a/sql/templates/group.html b/sql/templates/group.html
index 9593d48f03..e464837431 100644
--- a/sql/templates/group.html
+++ b/sql/templates/group.html
@@ -85,7 +85,7 @@
                 }],
                 onLoadSuccess: function () {
                 },
-                onLoadError: fonLoadErrorCallback,
+                onLoadError: onLoadErrorCallback,
                 onSearch: function (e) {
                     //传搜索参数给服务器
                     queryParams(e)
diff --git a/sql/templates/sqlquery.html b/sql/templates/sqlquery.html
index 46e1d5fe47..60deae3657 100644
--- a/sql/templates/sqlquery.html
+++ b/sql/templates/sqlquery.html
@@ -265,6 +265,7 @@ <h4 class="modal-title text-danger">收藏语句</h4>
     <script>
         //获取查询列表
         function get_querylog(query_log_id) {
+            var showExport = {{can_download}}===1
             //初始化table
             $('#sql-log').bootstrapTable('destroy').bootstrapTable({
                 escape: true,
@@ -280,7 +281,7 @@ <h4 class="modal-title text-danger">收藏语句</h4>
                 pageNumber: 1,                      //初始化加载第一页，默认第一页,并记录
                 pageSize: 14,                       //每页的记录行数（*）
                 pageList: [10, 30, 50, 100],        //可供选择的每页的行数（*）
-                showExport: true,                   //是否显示导出按钮
+                showExport: showExport,                   //是否显示导出按钮
                 exportTypes: ['json', 'sql', 'csv', 'txt', 'xml', 'xlsx'],
                 exportOptions: {
                     ignoreColumn: [0],  //忽略某些列的索引数组
@@ -781,11 +782,12 @@ <h4 class="modal-title text-danger">收藏语句</h4>
                         if (optgroup == 'Mongo') {
                             isdetail = true
                         }
+                        var showExport = {{can_download}}===1
                         $("#" + ('query_result' + n)).bootstrapTable('destroy').bootstrapTable({
                             escape: true,
                             data: result['rows'],
                             columns: columns,
-                            showExport: true,
+                            showExport: showExport,
                             exportDataType: "all",
                             exportTypes: ['json', 'sql', 'csv', 'txt', 'xml', 'xlsx'],
                             exportOptions: {
diff --git a/sql/views.py b/sql/views.py
index d41a24e805..7001e797a8 100644
--- a/sql/views.py
+++ b/sql/views.py
@@ -220,7 +220,8 @@ def sqlquery(request):
     # 收藏语句
     user = request.user
     favorites = QueryLog.objects.filter(username=user.username, favorite=True).values('id', 'alias')
-    return render(request, 'sqlquery.html', {'favorites': favorites})
+    can_download = 1 if user.has_perm('sql.download') or user.is_superuser else 0
+    return render(request, 'sqlquery.html', {'favorites': favorites, 'can_download':can_download})
 
 
 @permission_required('sql.menu_queryapplylist', raise_exception=True)
@@ -448,8 +449,7 @@ def audit_sqlquery(request):
     """SQL在线查询页面审计"""
     user = request.user
     favorites = QueryLog.objects.filter(username=user.username, favorite=True).values('id', 'alias')
-    is_download = 1 if user.has_perm('sql.download') or user.is_superuser else 0
-    return render(request, 'audit_sqlquery.html', {'favorites': favorites, 'is_download':is_download})
+    return render(request, 'audit_sqlquery.html', {'favorites': favorites})
 
 
 def audit_sqlworkflow(request):
diff --git a/src/init_sql/v1.8.3.sql b/src/init_sql/v1.8.3.sql
index 287873505c..732810c819 100644
--- a/src/init_sql/v1.8.3.sql
+++ b/src/init_sql/v1.8.3.sql
@@ -23,4 +23,9 @@ alter table audit_log add `user_display` varchar(50) DEFAULT NULL COMMENT '用
 
 set @content_type_id=(select id from django_content_type where app_label='sql' and model='permission');
 insert IGNORE INTO auth_permission (name, content_type_id, codename) VALUES
-('审计权限 ', @content_type_id, 'audit_user');
+('审计权限', @content_type_id, 'audit_user');
+
+-- 在线查询下载权限
+set @content_type_id=(select id from django_content_type where app_label='sql' and model='permission');
+insert IGNORE INTO auth_permission (name, content_type_id, codename) VALUES
+('在线查询下载权限', @content_type_id, 'query_download');
\ No newline at end of file